GeometryGym / GeometryGymIFC

C# classes to generate and parse OpenBIM IFC files
Other
282 stars 97 forks source link

import IfcBuildingElement #12

Open simonedd opened 6 years ago

simonedd commented 6 years ago

Hi,

I have a file with all elements of type IfcBuildingElement, I know that this type is abstract but other IFC reader import them. Is possible to import them also with this library?

jmirtsch commented 6 years ago

Hi,

I'm resisting to change the abstract nature of the class to handle this, but you can try the change I just made in the branch https://github.com/jmirtsch/GeometryGymIFC/tree/WorkInProgress

In BaseClassIFC in the method public static BaseClassIfc Construct(string className) I added two lines: if (string.Compare(className, "IfcBuildingElement", true) == 0) return Construct("IfcBuildingElementProxy");

If it doesn't work, then if you share a file I can take a look. You should also be reporting this back to the authoring application/toolkit to have it fixed at the source.

Cheers,

Jon

simonedd commented 6 years ago

Hi Jon,

I can't find the method public static BaseClassIfc Construct(string className) in BaseClassIFC or in other classes.

Best regards,

Simone

jmirtsch commented 6 years ago

It's not in the master branch yet, https://github.com/jmirtsch/GeometryGymIFC/blob/WorkInProgress/Core/IFC/BaseClassIFC.cs

simonedd commented 6 years ago

Hi,

Do you plan to merge the WorkingProgress with the stable release? If yes, do you know when it will be ready? I saw that there are many differences and I'm not sure I can safely replace the master branch in my application.

jmirtsch commented 6 years ago

Sure, there are many changes, and I've not had the time to ensure these changes are applied throughout the code base. Particularly for the collections of items. I really don't know when I will merge these commits into master, it might be quite some time yet. I personally am using the work in progress code in my own applications and it should be stable enough (just not particularly consistent).