search

GeometryGym / GeometryGymIFC

C# classes to generate and parse OpenBIM IFC files
Other
273 stars 97 forks source link

Typo exporting an IfcOpenCrossProfileDef instance #31

Closed seb-esser closed 4 years ago

seb-esser commented 4 years ago

Creating an instance of IfcOpenCrossProfileDef using: var profileDef = new IfcOpenCrossProfileDef(db, "profileName", true, new List<double>{2.0, 3.5}, new List<double>{0.1, 0.2}); Constructor in GeometryGymIfc.IFC.Core.IFC O.cs line 707 results in: #18= IFCOPENCROSSPROFILEDEF(.AREA.,'profileName',.T.,(2.0,3.5),(0.1,0.2),(#)); .

As I haven't set any tag list for the last attribute of IfcOpenCrossProfileDef, I would expect a nulled attribute value marked with $ instead of (#)

Did I miss something from the STEP side of things @pjanck ?

jmirtsch commented 4 years ago

Thanks for reporting this bug. I've just made a correction in the latest commit (including nuget package). Let me know if it's still amiss or if you find anything else amiss.

seb-esser commented 4 years ago

thanks for the fix. looks good now! #11= IFCOPENCROSSPROFILEDEF(.AREA.,'test',.T.,(2.0,2.4),(0.1,0.2),$);

Cheers, Sebastian