Fix file extension comparisons

GeometryGym / GeometryGymIFC

C# classes to generate and parse OpenBIM IFC files

Other

269 stars 97 forks source link

Fix file extension comparisons #56

Closed talanc closed 2 years ago

talanc commented 2 years ago

Fixes comparing file extensions. For example, "File.ifczip" would be recognised correctly, but "File.ifcZIP" would not (or any other permutation of lower/upper chars).

jmirtsch commented 2 years ago

Thanks for contributing this, it's a nice improvement.

talanc commented 2 years ago

I noticed you did a NuGet build (https://www.nuget.org/packages/GeometryGymIFC_Core) a few days ago, but the changes from this PR aren't included. I'm guessing it was just an oversight?

jmirtsch commented 2 years ago

Apologies, I built the dll from the WIP branch, and hadn't merged from Master. I have done so for the next build. If you want a nuget build updated, let me know and I'll process it ASAP.

talanc commented 2 years ago

No rush--it can wait.