search

GeometryGym / GeometryGymIFC

C# classes to generate and parse OpenBIM IFC files
Other
282 stars 97 forks source link

Blanks lost in originating_system field of FILE_NAME header data #80

Closed lorenzo-montesi closed 1 year ago

lorenzo-montesi commented 2 years ago

When parsing header data, the originating_system field of FILE_NAME, which is a string, loses all spaces between words. Furthermore, only timestamps and origining_system are parsed (e.g. author and organization are not)

jmirtsch commented 2 years ago

Thanks, I'm improving header parsing and retention as per this request. https://github.com/GeometryGym/GeometryGymIFC/discussions/79 I should have an implementation soon.

jmirtsch commented 2 years ago

I've revised the code in supporting a new attribute on the database storing STEP file header information. Refer here and let me know if you have any feedback for further improvements. https://github.com/GeometryGym/GeometryGymIFC/blob/09a0f173b59312bb9c548da8c61eb7677eaf0dde/Core/STEP/DatabaseSTEP.cs#L40

lorenzo-montesi commented 2 years ago

For me it's perfect. Thank you