search

GeometryGym / GeometryGymIFC

C# classes to generate and parse OpenBIM IFC files
Other
282 stars 97 forks source link

fixed STEP case for DatabaseIFC.ParseString #99

Closed keepdream1ng closed 6 months ago

keepdream1ng commented 7 months ago

Hello! I noticed that the current implementation of public static DatabaseIfc ParseString(string str) will return an empty database for the STEP format, but in this awesome library, there are some internal methods that will take care of such cases.

So I propose this change, which is rather small, yet fixes method behavior.

I also made a quick test for this fix, to ensure what files get to be parsed equally from files and from ParseString: testcase

jmirtsch commented 6 months ago

Thanks for contributing to the opensource toolkit. I will just adjust the line splitting so that it handles scenarios such as \r\n.