Class name seems incorrect

GeometryGym / GeometryGymIFCExamples

Examples to demonstrate use of https://github.com/jmirtsch/GeometryGymIFC classes

MIT License

60 stars 34 forks source link

Class name seems incorrect #7

Open pmorshed opened 2 years ago

pmorshed commented 2 years ago

Hi. In this example (line #36): https://github.com/GeometryGym/GeometryGymIFCExamples/blob/master/consoleSummarizeElements/Program.cs

What is "IfcBuildingElement"? There is no such a class in GeometryGymIfc. It seems it should be replaced with "IfcBuildingElementPart". I'm right?

jmirtsch commented 2 years ago

Hi,

In IFC4.3 (not finalized yet), there was a decision to deprecate the class IfcBuildingElement and introduced a new class IfcBuiltElement. As the GG toolkit supports simultaneous versions, we renamed the base class. I've just added a commit where this example is adjusted (and the others) to use the latest version of the nuget package. Thanks for raising this.