search

Geonovum / respec

A tool for creating technical documents and web standards. Geonovum fork to modify respec for own use.
Other
2 stars 1 forks source link

Some images not visible in local docs #153

Closed thijsbrentjens closed 5 years ago

thijsbrentjens commented 6 years ago

Important info

Description of problem

Some images are not shown. Docs are locally used/hosted, this issue needs more investigation for reproducing first, but I wanted to put it on the list already.

thijsbrentjens commented 5 years ago

In this doc images are not shown properly: https://geonovum.github.io/IMVG/#uitwerking

note to self: maybe we need some extra styling to explicitly set image sizes (width and height):

.figure img, .sidefigure img, figure img, .figure object, .sidefigure object, figure object {

    max-width: 100%;
    margin: auto;
    height: auto;
    width: auto;
}

Needs some testing.

thijsbrentjens commented 5 years ago

It seems that ReSpec adds a width="0" and height="0" attribute to a figure automatically.

marcoscaceres commented 5 years ago

oh, that's a bug. It should definitely not do that. It's supposed to add the a natural width and height.

thijsbrentjens commented 5 years ago

@marcoscaceres for now I'll add an extra CSS rule, to make sure images are shown, in addition to the existing one for figure img in base.css:

.figure img, .sidefigure img, figure img, .figure object, .sidefigure object, figure object {
 height: 100%;
 width: auto;
}
thijsbrentjens commented 5 years ago

Fixed after publication of update ReSpec build