As a general statement, tasks should be re-runable in Yocto. Some of our patch tasks patch and then patch over those patches dynamically, which means the original patch no longer apply at all (so it's not reversible). This causes extra pain when trying to develop patch sets against an asset because one cannot simply roll forwards and backwards in the patch history (in devshell using quilt, for example), because our do_patch[postfuncs] have sullied the environment.
More information: we currently use do_patch[postfuncs] in a few places to first tee-up things like BB_REDHAWK_PROCESSOR and then globally clobber it in the source tree with a sed expression. We have to do the same thing against Makefile.am for over half a dozen different things that are part of the core framework templates of existing assets. These kinds of patches should be moved to places like do_install[prefuncs], do_configure[prefuncs], etc. -- wherever it feels more appropriate. As always these functions should result in a no-operation if they've already applied their changes.
As a general statement, tasks should be re-runable in Yocto. Some of our
patchtasks patch and then patch over those patches dynamically, which means the original patch no longer apply at all (so it's not reversible). This causes extra pain when trying to develop patch sets against an asset because one cannot simply roll forwards and backwards in the patch history (indevshellusing quilt, for example), because ourdo_patch[postfuncs]have sullied the environment.More information: we currently use
do_patch[postfuncs]in a few places to first tee-up things like BB_REDHAWK_PROCESSOR and then globally clobber it in the source tree with asedexpression. We have to do the same thing againstMakefile.amfor over half a dozen different things that are part of the core framework templates of existing assets. These kinds of patches should be moved to places likedo_install[prefuncs],do_configure[prefuncs], etc. -- wherever it feels more appropriate. As always these functions should result in a no-operation if they've already applied their changes.