search

GeopJr / Collision

Check hashes for your files - A GUI tool to generate, compare and verify MD5, SHA-1, SHA-256, SHA-512, Blake3, CRC32 & Adler32 hashes.
https://collision.geopjr.dev
BSD 2-Clause "Simplified" License
138 stars 15 forks source link

feat(appdata): Improve appdata for AppStream 1.0 #179

Closed ghost closed 6 months ago

ghost commented 6 months ago
GeopJr commented 6 months ago

LGTM overall, thanks!

Just one question:

Your suggested id is github.com and the spec mentions The element should have a id property, containing a unique ID to identify the respective developer. It is recommended to use a web URL, like gnome.org as ID to achieve a higher chance of uniqueness.. I don't mind it but if it was chosen just because the app is on github, I'd probably choose something else as I don't know if it will stay here forever. I am not entirely sure what's the point of the id is either based on the spec, is it to distinguish me or the app? Would gnome.org (I am a member fwiw) or no id at all be better instead?

ghost commented 6 months ago

I've opened an issue regarding Appstream. You can find it here: Issue #575. Feel free to contribute to the discussion or provide any insights you may have.