search

GeopJr / Tuba

Browse the Fediverse
https://tuba.geopjr.dev/
GNU General Public License v3.0
504 stars 55 forks source link

fix(mv): video offload crash #1007

Closed GeopJr closed 2 weeks ago

GeopJr commented 2 weeks ago

fix: #1006

When offload is enabled, media_stream might be null by the time done is called. Technically, that shouldn't be the case. done is called after the video finishes downloads and gets set.

Either way, now if media_stream is null, it will listen to its notify signal, and if it becomes non-null it will proceed with the done process.

Now there's the following criticals:

(dev.geopjr.Tuba:179669): GStreamer-Player-CRITICAL **: 00:09:55.248: gst_player_set_mute: assertion 'GST_IS_PLAYER (self)' failed

(dev.geopjr.Tuba:179669): GStreamer-Player-CRITICAL **: 00:09:55.248: gst_player_set_volume: assertion 'GST_IS_PLAYER (self)' failed

(dev.geopjr.Tuba:179669): GStreamer-Player-CRITICAL **: 00:09:55.248: gst_player_set_mute: assertion 'GST_IS_PLAYER (self)' failed

(dev.geopjr.Tuba:179669): GStreamer-Player-CRITICAL **: 00:09:55.248: gst_player_set_volume: assertion 'GST_IS_PLAYER (self)' failed

non-fatal however

edit:

FWIW, it's not prepared nor does it become later

edit 2:

Changing the volume before becoming the visible child of the stack, caused the other issue