search

GeopJr / Tuba

Browse the Fediverse
https://tuba.geopjr.dev/
GNU General Public License v3.0
504 stars 55 forks source link

[Request]: Make alert dialogs HIG compliant #1036

Open jamiethecat opened 1 week ago

jamiethecat commented 1 week ago

Describe the request

Currently, the app tends to use sentences in titles when it comes to alert dialogs. The title should be title case and contain 2-4 words. Descriptions shouldn't use a period if they contain a single sentence.

Implementation Details

GeopJr commented 6 days ago

On the '2-4 words' part, not sure how to comply on some stuff, e.g.

"Are you sure you want to no longer federate with %s?", is definitely too wordy for a title, but also I have no idea what the title should be instead

Similarly, another edge case is:

title: "Are you sure you want to block %s?" subtitle: "This can be the domain name that shows up in the e-mail address or the MX record it uses. They will be checked upon sign-up."

If you want to give it a try, I'll accept any changes you make, but I'm really bad at this lol

P.S. you can search for them in the source code by Adw.AlertDialog and app.question (<-- higher level api that uses alert dialogs)

jamiethecat commented 6 days ago

"Are you sure you want to no longer federate with %s?", is definitely too wordy for a title, but also I have no idea what the title should be instead

"Stop Federating With %s?"

"Are you sure you want to block %s?"

"Block %s?"

I'm a bit busy right now so I can't make the changes myself 😔

GeopJr commented 6 days ago

I see, thanks!

I'm a bit busy right now so I can't make the changes myself 😔

No worries! (they'll have to wait for 0.9 anyway, so I'll go over them at a later point)