GeopJr / Tuba

Browse the Fediverse
https://tuba.geopjr.dev/
GNU General Public License v3.0
574 stars 61 forks source link

[Request]: Clicking outside of an image should close it #148

Open forteller opened 1 year ago

forteller commented 1 year ago

Describe the request

This is very natural and default in many apps. Thanks!

Implementation Details

GeopJr commented 1 year ago

I don't feel that confident about this. The media viewer is not a modal (like Mastodon Web) but a different view (like Mastodon Mobile).

It's closer to this: image

Than this: image

There's also the question of sizing. Currently the images expand, taking as much space as possible while keeping aspect ratio. That makes zooming a bit more complex but it results in 99% of users not having to use zoom at all to view images. Having the images be a static size or having enough padding around them as "blank space for dismissing" would require all users to use the zoom functions which is not ideal (and disabled on videos/gifs/audio).

Screencast from 2023-07-13 05-07-24.webm

Note that Tuba's media viewer is not meant to replace your host's. It's meant to view/play multiple formats without opening them externally (images, videos, audio).

This needs more thought.

cc: @eobet

eobet commented 1 year ago

I like both clicking on the background and swiping down to close the media as suggested here by @CaptainMorgan12.

As mentioned both here and in that other issue, many other apps use both interactions and the more interactions possible to achieve the same thing, the less pain points new users encounter