[Request]: Full-width media

[bertob]

Describe the request

It's a bit odd that images only use half the width when there's just one, especially at narrower widths. Could we special case the single image case and use the full wdith?

Implementation Details

• [ ] This should be an option in settings.
• [ ] This should be only available to some fediverse backends. (Include which ones on the above field).
• [ ] This is client-only (and shouldn't sync with the instance).
• [X] This follows the GNOME HIG.

[GeopJr]

like so?

we can also increase the height:

[bertob]

Yeah, increasing the height sounds good, so the aspect ratio doesn't get too wide. Could go even taller than what you have there, IMO. Elk doesn't seem to limit the height at all, which seems like a bit much too me. I'd try 4:3 or square as the max aspect ratio.

[GeopJr]

4:3

square

[bertob]

I think square could work, but I would not force an aspect ratio for landscape images, and just show the whole image instead, i.e. images taller than 1:1 would be scaled up and clipped, while images wider than 1:1 would be scaled down and shown without cropping (maybe up to a minimum height of like 100px or so, after which they should probably be scaled up and cropped to keep them a reasonable aspect ratio).

[bertob]

This looks fixed to me on the latest main:

[GeopJr]

It just makes the attachment bigger, it does not follow the previous comment https://github.com/GeopJr/Tuba/issues/180#issuecomment-1502824771 so I left it open (unless it's good enough as is?)

[bertob]

Mmmh, not sure I follow what it doesn't do to be honest :D

[GeopJr]

Currently the attachment is either cover fitted (the default) or contain fitted (if enabled in settings (letterbox))

images taller than 1:1 would be scaled up and clipped

:heavy_check_mark: cover takes care of it

while images wider than 1:1 would be scaled down and shown without cropping (maybe up to a minimum height of like 100px or so, after which they should probably be scaled up and cropped to keep them a reasonable aspect ratio).

:x: The following image

will look like this

while you probably are looking for something like this

[bertob]

Ah, gotcha! Thanks for explaining, and yes that is what I had in mind :)