[Request]: Use dim-label style class in TubaWidgetsNotification when a notification has been visited

GeopJr / Tuba

Browse the Fediverse

https://tuba.geopjr.dev/

GNU General Public License v3.0

572 stars 61 forks source link

[Request]: Use dim-label style class in TubaWidgetsNotification when a notification has been visited #406

Open CleoMenezesJr opened 1 year ago

CleoMenezesJr commented 1 year ago

Describe the request

Here some example on how it looks like:

This will help the user to know which notifications have not yet been seen. I don't know the Fediverse API and I don't know if there is any parameter that says if the notification was seen or not. If not, ignore this request.

Implementation Details

[ ] This should be an option in settings.
[X] This should be only available to some fediverse backends. (Include which ones on the above field).
[ ] This is client-only (and shouldn't sync with the instance).
[X] This follows the GNOME HIG.

CleoMenezesJr commented 1 year ago

https://github.com/GeopJr/Tuba/blob/44136b8cde706420df4a9dd809ff8a1be469b420/src/API/Notification.vala#L31

Looks like you're doing something in this context. Don't you?

GeopJr commented 1 year ago

Thanks for the suggestion!

It sounds good and could be implemented from our side but it can't be done through the api (and therefore won't be synced among clients).

Here's how notifications work:

on start, Tuba reads how many notifications are unread and sets up the tab badge
when a notification is received, Tuba sends a desktop notification and updates the tab badge
when the notification tab is visited, Tuba sets the last read notification id on the api (which is the most recent notification) and clears the tab badge

Looks like you're doing something in this context. Don't you?

This is from Tootle and it's about desktop notification buttons (clicking it would do the same as above + withdraw the desktop notification)

danialbehzadi commented 2 weeks ago

This can be done via notifications timeline marker: https://docs.joinmastodon.org/methods/markers

GeopJr commented 2 weeks ago

The markers only show the end, not individual notifications. What this request is about is when clicking on a notification, it should become dimmed, not everything up to this notification, just the one you clicked.

For example in the screenshot in the issue body, the first 2 newest notifications are marked as read/dimmed but the 2 older ones haven't.