GeopJr / Tuba

Browse the Fediverse
https://tuba.geopjr.dev/
GNU General Public License v3.0
572 stars 61 forks source link

Post reactions #44

Closed GeopJr closed 4 weeks ago

GeopJr commented 1 year ago

You can view reactions as of https://github.com/GeopJr/Tooth/commit/2df67299a07ea4896a1f8b115c34d771f9f55d13

cyrneko commented 2 months ago

You can view reactions as of 2df6729

Any plans of making them actionable under Chuckya/Glitch-Soc?

GeopJr commented 2 months ago

I'm kinda waiting for glitch-soc to merge it because apart from it there are two competing implementations:

I think the current runner up for glitch-soc follows the Akkoma one(?) so that will be the one we implement I guess. But until it gets merged I'm a bit hesitant to implement it

cyrneko commented 2 months ago

I'm kinda waiting for glitch-soc to merge it because apart from it there are two competing implementations:

* Akkoma(/Pleroma(?)) allows you to do multiple reactions and favorite a post

* Misskey on forks that have somewhat masto api compat allow you to either favorite or react

I think the current runner up for glitch-soc follows the Akkoma one(?) so that will be the one we implement I guess. But until it gets merged I'm a bit hesitant to implement it

I mean, it is downstream in Chuckya which is already used on instances, primarily wetdry.world, in production

It does follow the Akkoma model, you can favourite and react. With wdw's config you can react with one reaction at most + a fav

Though judging from my notifications from key users, they can also* do both (react+fav) if they so wish

GeopJr commented 2 months ago

I mean, it is downstream in Chuckya which is already used on instances, primarily wetdry.world, in production

I'd still rather wait. Chuckya and downstreams depend on glitch-soc's design decisions still, say glitch-soc decides to do something as simple as change the API endpoint for it, then downstreams will follow.

Of course that is not set in stone, but I'd really prefer if we didn't have to go back to it again and again because it's not merged yet and stuff might change :/

GeopJr commented 4 weeks ago

Ended up adding support for the Chuckya API, but istg if they change it last minute :anger: