GeopJr / Tuba

Browse the Fediverse
https://tuba.geopjr.dev/
GNU General Public License v3.0
572 stars 61 forks source link

[Request]: close button in media viewer closes media viewer only #586

Open teemuxyz opened 1 year ago

teemuxyz commented 1 year ago

Describe the request

I keep clicking the close button in the media viewer thinking it will only close the media viewer and not the whole app. I think the former behaviour is more in line with the Gnome HIG, so I suggest changing it to that. Alternatively, make it more visually obvious that the close button closes the whole app in viewer mode also.

Implementation Details

GeopJr commented 1 year ago

The media viewer is not a separate window. The close button has the same behavior across all apps - it closes the window, not sure how it can be made more obvious, it already has a different style from the rest of the headerbar items. There's already a back button on the media viewer, interfering with the close button just for an action that already exists on the headerbar is a no-go and will distort user expectations of other instances of the close button. In general, close button => close window and the media viewer is in the main window.