GeopJr / Tuba

Browse the Fediverse
https://tuba.geopjr.dev/
GNU General Public License v3.0
557 stars 60 forks source link

[Bug]: Overlay zoom buttons shown over enlarged videos and audio embeds #870

Closed nekohayo closed 6 months ago

nekohayo commented 6 months ago

Describe the bug

When clicking to enlarge some video/audio media that is not a still image, the + / - zoom buttons are still shown (but disabled), although they don't make sense, especially as they overlap with the seek bar's controls. It would be better to hide them.

Steps To Reproduce

  1. Click a toot containing an embedded audio (sample) or native video (sample) to view its details and enlarge it
  2. Click the media to play it

Logs and/or Screenshots

image

Instance Backend

Mastodon

Operating System

Fedora 39

Package

Flatpak

Troubleshooting information

os: GNOME 46 (Flatpak runtime) prefix: /app flatpak: true version: 0.7.0 (production) gtk: 4.14.1 (4.14.1) libadwaita: 1.5.0 (1.5.0) libsoup: 3.4.4 (3.4.4) libgtksourceview: 5.12.0 (5.12.0)

Additional Context

No response

GeopJr commented 6 months ago

This will 100% be fixed by #869 (race condition, it checks if it's a video before resolving it - not meant to be shown on videos!)