search

GeopJr / Tuba

Browse the Fediverse
https://tuba.geopjr.dev/
GNU General Public License v3.0
575 stars 62 forks source link

[Bug]: New Filter dialog is small #871

Open RocketRide9 opened 8 months ago

RocketRide9 commented 8 months ago

Describe the bug

New Filter default size is too small. It's default size could be made bigger.

Steps To Reproduce

  1. Go to Settings
  2. Filters
  3. Add Filter...
  4. See dialog window

Logs and/or Screenshots

изображение

IMO dialog should be bigger to fit it's content without scrolling

Instance Backend

Mastodon

Operating System

Linux

Package

Flatpak

Troubleshooting information

No response

Additional Context

No response

GeopJr commented 8 months ago

Thanks for the suggestion!

One thing I'd like to preserve is the 'depth' of the dialogs. I want the "Filter edit" dialog to still seem as if it's a dialog of the "Preferences" dialog. Higher values while they look ok when the window in also big, they start losing their 'depth' as the window shrinks:

Screencast from 2024-03-24 01-48-57.webm

Maybe I'm overthinking it and 'depth' isn't that important? The dialogs are new so I don't really know what patterns other gnome apps follow :/

Let me know what you think

IMO dialog should be bigger to fit it's content without scrolling

Not really possible, the content height could be very high based on the amount of keywords, and is definitely bigger than most typical window sizes

nekohayo commented 8 months ago

In case some of the tricks here are useful, for dynamically figuring out the needed height, see this article.

In an ideal world, I'd recommend a UI that adapts on the desktop to use wider windows, with contents of that dialog being separated into multiple columns to make use of the generous amount of horizontal space on a landscape computer display, but I understand that this would be an effort that may complexify the code…

GeopJr commented 8 months ago

I don't think a multi column to single column adaptive layout can be easily implemented. There are many edge cases with widget sizing and whatnot. Looking for example at Newsflash, which has 3 'columns', to get around it, it uses multiple nested split layouts :shrug:

I can do multiple pages, like the preferences dialog, if there's too much on the filter edit one. "General", "Contexts", "Keywords"