search

GeopJr / Tuba

[On break until 2024-07-15] Browse the Fediverse
https://tuba.geopjr.dev/
GNU General Public License v3.0
511 stars 55 forks source link

fix: fractional scaling blurriness with gl #886

Closed GeopJr closed 3 months ago

GeopJr commented 3 months ago

fix: #885

On 46, GTK defaults to ngl as its renderer. While it's a nice step forward, performance is not on par with gl yet and is very noticeable on Tuba, so we forced gl as the default on #847 until everything gets ironed out (gl is being used only if nothing else is set, so you can still override it).

On #885 an issue with fractional scaling and blurriness was raised and after researching on GTK's issue tracker, I discovered that setting GDK_DEBUG=gl-no-fractional reproduced the old behavior. This PR sets that if the renderer is gl.

thibaultamartin commented 3 months ago

Would you consider doing a minor release solely for this fix? It might not be much in terms of code, but the impact is pretty significant for end users :)

GeopJr commented 3 months ago

It will be a patch! But I'm holding off until the end of the week in case anything else critical or a translation fix comes up

In the meantime, if you are using the flatpak, you can run flatpak override --env=GDK_DEBUG=gl-no-fractional dev.geopjr.Tuba to override it

(though it might cause issues when we move to ngl eventually)

GeopJr commented 3 months ago

(Btw, Image Viewer (Loupe), also uses gl instead of ngl and suffered from the same thing. I echoed this issue there and the fix will be available on the next release)