search

GeopJr / Tuba

[On break until 2024-07-15] Browse the Fediverse
https://tuba.geopjr.dev/
GNU General Public License v3.0
511 stars 55 forks source link

fix(composer): pixelfed posting #896

Closed GeopJr closed 3 months ago

GeopJr commented 3 months ago

fix: #895

The first commit will fix it but I'm not sure if the second should be merged.

The first issue is that Pixelfed for some reason broke their custom emojis api but also Vala's optional chaining not working as always. So it could be null and still return as truthy.

The second issue, which was just critical logs from json glib but should be taken into account, was that when attempting to get the json root, it could not be an object, as many edge cases are valid json but useless to us.

It makes sense to check but is also useless to assume that a server could not return an object. Well, if they implement mastoapi that is.

GeopJr commented 3 months ago

Reverted the second part for now.