GeopJr / Tuba

Browse the Fediverse
https://tuba.geopjr.dev/
GNU General Public License v3.0
506 stars 55 forks source link

[Bug]: quote posts shown without the quoted post when loaded from gts #926

Closed selfisekai closed 2 months ago

selfisekai commented 2 months ago

Describe the bug

when showing a quote post loaded from a gotosocial instance, tuba does not show the "RE:" line with a link (as it does if loaded from mastodon), and the attached post preview does not exist in response either (as from akkoma)

Steps To Reproduce

  1. use a gts account
  2. open a post quoting another post

Logs and/or Screenshots

post as fetched from my instance

        {
            "account": {
                "acct": "mwk@donotsta.re",
                "url": "https://donotsta.re/users/mwk",
                "username": "mwk"
            },
            "content": "<span class=\"h-card\"><a class=\"u-url mention\" href=\"https://queer.party/@yavien\" rel=\"ugc nofollow noreferrer noopener\" target=\"_blank\">@<span>yavien</span></a></span> seconded from my own personal experience<span class=\"quote-inline\"><br><br>RE: <a href=\"https://queer.party/users/yavien/statuses/112333867184539778\" rel=\"nofollow noreferrer noopener\" target=\"_blank\">https://queer.party/users/yavien/statuses/112333867184539778</a></span>",
            "created_at": "2024-04-25T21:11:54.950Z",
            "id": "01HWBHKGA608MC7J6ZK2V40MQ1",
            "mentions": [
                {
                    "acct": "yavien@queer.party",
                    "id": "01HSY5W5KFNKP3J5EZRY3EVX37",
                    "url": "https://queer.party/@yavien",
                    "username": "yavien"
                }
            ],
            "uri": "https://donotsta.re/objects/af6959d1-545e-42dc-90b1-7cef62bf11c0",
            "url": "https://donotsta.re/objects/af6959d1-545e-42dc-90b1-7cef62bf11c0",
            "visibility": "public"
        }

Instance Backend

GoToSocial

Operating System

Alpine Linux edge

Package

OS repositories

Troubleshooting information

os: Alpine Linux (null) prefix: /usr flatpak: false version: 0.7.2 (production) gtk: 4.14.2 (4.14.1) libadwaita: 1.5.0 (1.5.0) libsoup: 3.4.4 (3.4.4) libgtksourceview: 5.12.0 (5.12.0)

Additional Context

No response

GeopJr commented 2 months ago

Okay so,

fetching it from infosec.place (akkoma), I get:

```json { "tags": [], "id": "AhG8eo07pub5ZvAKP2", "reblogs_count": 0, "akkoma": { "source": { "content": "@yavien@queer.party seconded from my own personal experience", "mediaType": "text/plain" } }, "content": "@yavien seconded from my own personal experience", "pleroma": { "local": false, "context": "tag:queer.party,2024-04-25:objectId=106145430:objectType=Conversation", "content": { "text/plain": "@yavien seconded from my own personal experience" }, "expires_at": null, "direct_conversation_id": null, "spoiler_text": { "text/plain": "" }, "emoji_reactions": [], "pinned_at": null, "conversation_id": 494767473, "in_reply_to_account_acct": null, "parent_visible": false, "thread_muted": false }, "emojis": [], "language": "en", "application": null, "bookmarked": false, "emoji_reactions": [], "sensitive": false, "reblogged": false, "url": "https://donotsta.re/objects/af6959d1-545e-42dc-90b1-7cef62bf11c0", "in_reply_to_id": null, "text": null, "spoiler_text": "", "edited_at": null, "pinned": false, "muted": false, "mentions": [ { "id": "AbuiV86hA79STB6xua", "url": "https://queer.party/@yavien", "username": "yavien", "acct": "yavien@queer.party" } ], "quote": { "tags": [], "id": "AhG8entOExD3F20wu8", "reblogs_count": 0, "akkoma": { "source": null }, "content": "

I have been a flatmate of Amie Raine and her girlfriend Lily for 9 months. In light of recent events, I think it's time to speak out publicly: I believe Amie and Lily are serial liars with a penchant for destroying communities and targeted harassment of equally marginalized people as them. I believe virtually everyone should:
- doubt everything they say, esp their career experience
- doubt their numerous call-outs and abuse allegations
- not take ANY medical advice from them
- not take any drugs (medical, recreational, w/e) from them or around them. They don't know anything about the "harm reduction" they preach.
- avoid any romantic, sexual or close platonic (if not all kinds of platonic) relationships with them.

", "pleroma": { "local": false, "context": "tag:queer.party,2024-04-25:objectId=106145430:objectType=Conversation", "content": { "text/plain": "I have been a flatmate of Amie Raine and her girlfriend Lily for 9 months. In light of recent events, I think it's time to speak out publicly: I believe Amie and Lily are serial liars with a penchant for destroying communities and targeted harassment of equally marginalized people as them. I believe virtually everyone should:- doubt everything they say, esp their career experience- doubt their numerous call-outs and abuse allegations- not take ANY medical advice from them- not take any drugs (medical, recreational, w/e) from them or around them. They don't know anything about the \"harm reduction\" they preach.- avoid any romantic, sexual or close platonic (if not all kinds of platonic) relationships with them." }, "expires_at": null, "direct_conversation_id": null, "spoiler_text": { "text/plain": "" }, "emoji_reactions": [], "pinned_at": "2024-04-25T21:35:31.000Z", "conversation_id": 494767473, "in_reply_to_account_acct": null, "parent_visible": false, "thread_muted": false }, "emojis": [], "language": "en", "application": null, "bookmarked": false, "emoji_reactions": [], "sensitive": false, "reblogged": false, "url": "https://queer.party/@yavien/112333867184539778", "in_reply_to_id": null, "text": null, "spoiler_text": "", "edited_at": null, "pinned": true, "muted": false, "mentions": [], "quote": null, "visibility": "public", "uri": "https://queer.party/users/yavien/statuses/112333867184539778", "poll": null, "quote_id": null, "created_at": "2024-04-25T20:59:43.000Z", "card": null, "media_attachments": [], "account": { "id": "AbuiV86hA79STB6xua", "header": "https://content.queer.party/media/accounts/headers/000/112/515/original/24668cd43824fd07.jpeg", "fields": [ { "name": "Pronouns", "value": "they/them" }, { "name": "Age", "value": "27" } ], "source": { "sensitive": false, "fields": [], "pleroma": { "actor_type": "Person", "discoverable": false }, "note": "" }, "pleroma": { "background_image": null, "skip_thread_containment": false, "tags": [], "ap_id": "https://queer.party/users/yavien", "is_moderator": false, "is_admin": false, "also_known_as": [], "hide_follows": false, "hide_follows_count": false, "hide_followers": false, "hide_followers_count": false, "favicon": "https://queer.party/favicon.ico", "is_confirmed": true, "is_suggested": false, "hide_favorites": true, "relationship": {} }, "url": "https://queer.party/@yavien", "username": "yavien", "created_at": "2023-11-18T00:13:00.000Z", "emojis": [], "following_count": 0, "last_status_at": "2024-04-25", "note": "

yavien on cohost, yavieniv on twt if its still alive

", "acct": "yavien@queer.party", "akkoma": { "instance": { "name": "queer.party", "favicon": "https://queer.party/favicon.ico", "nodeinfo": { "metadata": {}, "openRegistrations": false, "protocols": [ "activitypub" ], "services": { "inbound": [], "outbound": [] }, "software": { "name": "mastodon", "version": "4.2.8" }, "usage": { "localPosts": 1061284, "users": { "activeHalfyear": 646, "activeMonth": 430, "total": 6144 } }, "version": "2.0" } }, "status_ttl_days": null, "permit_followback": false }, "avatar": "https://content.queer.party/media/accounts/avatars/000/112/515/original/7b44485498c5a164.png", "avatar_static": "https://content.queer.party/media/accounts/avatars/000/112/515/original/7b44485498c5a164.png", "bot": false, "display_name": "yavien", "followers_count": 0, "fqn": "yavien@queer.party", "header_static": "https://content.queer.party/media/accounts/headers/000/112/515/original/24668cd43824fd07.jpeg", "locked": false, "statuses_count": 11 }, "in_reply_to_account_id": null, "favourites_count": 0, "favourited": false, "reblog": null, "replies_count": 1 }, "visibility": "public", "uri": "https://donotsta.re/objects/af6959d1-545e-42dc-90b1-7cef62bf11c0", "poll": null, "quote_id": "AhG8entOExD3F20wu8", "created_at": "2024-04-25T21:11:54.000Z", "card": null, "media_attachments": [], "account": { "id": "AXwJqWKK4S3sDlqiEy", "header": "https://asdf.donotsta.re/media/4175b393f29f2140933955a9f80ce09510db1da151c9676eee620007ac776701.jpg", "fields": [ { "name": "pronouns", "value": "she/it" }, { "name": "species", "value": "housecat (large)" }, { "name": "blood type", "value": "blue" }, { "name": "meat age", "value": "≥30" }, { "name": "pfp source", "value": "https://picrew.me/share?cd=akImGsvmsD" }, { "name": "github", "value": "https://github.com/wanda-phi/" } ], "source": { "sensitive": false, "fields": [], "pleroma": { "actor_type": "Person", "discoverable": false }, "note": "" }, "pleroma": { "background_image": null, "skip_thread_containment": false, "tags": [], "ap_id": "https://donotsta.re/users/mwk", "is_moderator": false, "is_admin": false, "also_known_as": [], "hide_follows": false, "hide_follows_count": false, "hide_followers": false, "hide_followers_count": false, "favicon": "https://donotsta.re/favicon.png", "is_confirmed": true, "is_suggested": false, "hide_favorites": true, "relationship": {} }, "url": "https://donotsta.re/users/mwk", "username": "mwk", "created_at": "2023-07-22T03:17:45.000Z", "emojis": [], "following_count": 0, "last_status_at": "2024-04-25", "note": "a girl afraid of herself", "acct": "mwk@donotsta.re", "akkoma": { "instance": { "name": "donotsta.re", "favicon": "https://donotsta.re/favicon.png", "nodeinfo": { "metadata": { "accountActivationRequired": true, "features": [ "pleroma_api", "akkoma_api", "mastodon_api", "mastodon_api_streaming", "polls", "v2_suggestions", "pleroma_explicit_addressing", "shareable_emoji_packs", "multifetch", "pleroma:api/v1/notifications:include_types_filter", "quote_posting", "editing", "bubble_timeline", "relay", "pleroma_emoji_reactions", "exposable_reactions", "profile_directory", "custom_emoji_reactions", "pleroma:get:main/ostatus" ], "federatedTimelineAvailable": true, "federation": { "enabled": true, "exclusions": false, "mrf_hashtag": { "federated_timeline_removal": [], "reject": [], "sensitive": [ "nsfw" ] }, "mrf_hellthread": { "delist_threshold": 15, "reject_threshold": 20 }, "mrf_object_age": { "actions": [ "delist", "strip_followers" ], "threshold": 604800 }, "mrf_policies": [ "ObjectAgePolicy", "TagPolicy", "SimplePolicy", "HellthreadPolicy", "RejectNewlyCreatedAccountNotesPolicy", "HashtagPolicy", "InlineQuotePolicy", "NormalizeMarkup", "DirectMessageDisabledPolicy" ], "mrf_simple": { "accept": [], "avatar_removal": [], "banner_removal": [], "federated_timeline_removal": [ "mastodon.social", "101010.pl" ], "followers_only": [ "101010.pl" ], "media_nsfw": [], "media_removal": [], "reject": [ "spinster.xyz", "freespeechextremist.com", "glindr.org", "baraag.net", "gleasonator.com", "freezepeach.xyz", "shitposter.club", "unsafe.space", "noagenda.social", "preteengirls.biz", "libertarianism.club", "toot.love", "pleroma.cucked.me", "wxw.moe", "gameliberty.club", "rubber.social", "neckbeard.xyz", "kiwifarms.net", "kiwifarms.is", "speakfree.world", "kiwifarms.cc", "noagendasocial.com", "social.getgle.org", "pieville.net", "sneed.network", "monads.online", "nitecrew.rip", "woln.eu", "neenster.org", "fans.sonichu.com", "detroitriotcity.com", "clubcyberia.co", "bae.st", "eientei.org", "ryona.agency", "rdrama.cc", "beefyboys.win", "varishangout.net", "bridge.birb.space", "eveningzoo.club", "nicecrew.digital", "mugicha.club", "chudbuds.lol", "sleepy.cafe", "normie.cafe", "geofront.rocks", "shitpost.cloud", "seal.cafe", "comfyboy.club", "calobar.club", "wolfgirl.bar", "honkwerx.tech", "leafposter.club", "fedi.intkos.link", "pkteerium.xyz", "rebased.io", "zov.oti.st", "yggdrasil.social", "freecumextremist.com", "a.sc", "obo.sh", "eatthebugs.social", "cyberstorm.one", "rojogato.com", "posting.lolicon.rocks", "f.haeder.net", "rigcz.club", "me.dm", "rapemeat.solutions", "negroes.forsale", "pedo.school", "cum.salon", "privex.social", "seo.chat", "morale.ch", "soc.ua-fediland.de", "wizzzard.online", "freak.university", "sneed.social", "brighteon.social", "pl.kitsunemimi.club", "glee.li", "flipboard.social", "pleroma.narrativerry.xyz", "mastodon.cysioland.pl", "republic.red", "social.lovingexpressions.net", "newsie.social", "mostr.pub", "freeatlantis.com", "berserker.town", "merovingian.club", "social.snorklr.com", "bassam.social", "boks.moe", "thebag.social", "bozgor.com", "federated.fun", "poa.st", "femboys.love", "plaugu.ee", "decayable.ink", "threads.net", "social.overheid.nl", "amsterdam.nl", "social.network.europa.eu", "bronyfurry.com", "social.bbc", "pettanko.art", "minds.com", "social.admin.ch", "friendica.eskimo.com", "rapemeat.express", "moar.cachapa.xyz", "gearlandia.haus", "mastodon.staycuriousandkeepsmil.in", "childlove.space", "rape.pet", "flipboard.com", "comp.lain.la", "the.asbestos.cafe", "cawfee.club", "boymoder.biz", "netzsphaere.xyz", "social.numerique.gouv.fr", "annihilation.social", "bsky.brid.gy", "social.cutefunny.net", "cunnyborea.top", "friendsyu.me" ], "reject_deletes": [], "report_removal": [] }, "mrf_simple_info": { "federated_timeline_removal": { "101010.pl": { "reason": "drama queens leaning right" }, "mastodon.social": { "reason": "the fucking matrix.org of fedi" } }, "followers_only": { "101010.pl": { "reason": "drama queens leaning right" } }, "reject": { "mostr.pub": { "reason": "harassment of instance members" }, "friendsyu.me": { "reason": "spam" }, "mastodon.cysioland.pl": { "reason": "they acted weird towards me a few times; single user instance" }, "honkwerx.tech": { "reason": "transphobia" }, "childlove.space": { "reason": "weirdos" }, "moar.cachapa.xyz": { "reason": "transphobia, \"free speech\"" }, "bozgor.com": { "reason": "anti-abortion, racism" }, "social.bbc": { "reason": "corpo :v" }, "spinster.xyz": { "reason": "transphobia" }, "bassam.social": { "reason": "antisemitism, \"free speech\"" }, "threads.net": { "reason": "preemptive block for IG" }, "seo.chat": { "reason": "no thanks" }, "social.numerique.gouv.fr": { "reason": "no governments, k thanks" }, "f.haeder.net": { "reason": "transphobia" }, "nicecrew.digital": { "reason": "transphobia" }, "cyberstorm.one": { "reason": "nazism, racism" }, "me.dm": { "reason": "seriously, medium?" }, "soc.ua-fediland.de": { "reason": "spam, nazis" }, "wizzzard.online": { "reason": "tankies (monads)" }, "neenster.org": { "reason": "transphobia / queerphobia" }, "gearlandia.haus": { "reason": "transphobia / queerphobia" }, "sneed.social": { "reason": "transphobia, homophobia seemingly masqueraded as ironic support???" }, "shitpost.cloud": { "reason": "transphobia, homophobia, nazism AND racism. what a combo" }, "cunnyborea.top": { "reason": "spam" }, "comfyboy.club": { "reason": "racism; far right ppl" }, "femboys.love": { "reason": "instance filled with trolls from twt" }, "eatthebugs.social": { "reason": "free speech extremists, tinfoilers" }, "shitposter.club": { "reason": "transphobia" }, "rapemeat.express": { "reason": "..." }, "ryona.agency": { "reason": "transphobia, racism, blocklist scraping" }, "cum.salon": { "reason": "..." }, "a.sc": { "reason": "transphobia" }, "social.network.europa.eu": { "reason": "no governments, k thanks" }, "privex.social": { "reason": "shady/crypto stuff + corpos" }, "leafposter.club": { "reason": "transphobia" }, "obo.sh": { "reason": "no moderation, lolifox" }, "zov.oti.st": { "reason": "transphobia" }, "boymoder.biz": { "reason": "associated with asbestoscafe" }, "boks.moe": { "reason": "transphobia, queerphobia, white supremacy" }, "social.snorklr.com": { "reason": "rightist idiots, conspiracy theorists" }, "rapemeat.solutions": { "reason": "..." }, "minds.com": { "reason": "the pay2win gab, lol, lmao" }, "freak.university": { "reason": "openly supports zoophiles and pedos" }, "negroes.forsale": { "reason": "..." }, "detroitriotcity.com": { "reason": "transphobia / queerphobia" }, "beefyboys.win": { "reason": "weird pervs" }, "calobar.club": { "reason": "transphobia" }, "gleasonator.com": { "reason": "transphobia" }, "republic.red": { "reason": "transphobes, antivax" }, "varishangout.net": { "reason": "transphobia" }, "amsterdam.nl": { "reason": "no governments, k thanks" }, "social.admin.ch": { "reason": "no government" }, "pl.kitsunemimi.club": { "reason": "transphobia" }, "eveningzoo.club": { "reason": "racism / transphobia" }, "rebased.io": { "reason": "transphobia" }, "social.overheid.nl": { "reason": "no governments, k thanks" }, "pleroma.narrativerry.xyz": { "reason": "transphobia, they are an idiot, etc" }, "flipboard.com": { "reason": "please do not litter, bad corpo" }, "seal.cafe": { "reason": "transphobia" }, "bsky.brid.gy": { "reason": "a hell nah man" }, "sleepy.cafe": { "reason": "transphobia" }, "freeatlantis.com": { "reason": "harassment of instance members" }, "posting.lolicon.rocks": { "reason": "racism..." }, "social.cutefunny.net": { "reason": "cp" }, "eientei.org": { "reason": "transphobia / queerphobia" }, "rdrama.cc": { "reason": "transphobia, racism" }, "wolfgirl.bar": { "reason": "transphobia" }, "bridge.birb.space": { "reason": "possible spam" }, "noagendasocial.com": { "reason": "transphobia" }, "bae.st": { "reason": "transphobia / queerphobia" }, "friendica.eskimo.com": { "reason": "climate change deniers, antisemitism, transphobia, etc" }, "glee.li": { "reason": "racism, queermisia, trolling" }, "yggdrasil.social": { "reason": "transphobia" }, "decayable.ink": { "reason": "racism" }, "plaugu.ee": { "reason": "associated with ryona.agency" }, "poa.st": { "reason": "transphobia / homophobia / racism / queerphobia / nazi combo instance" }, "rape.pet": { "reason": "weirdos / CP" }, "thebag.social": { "reason": "transphobia, far rightists, xenophobia" }, "pettanko.art": { "reason": "cp" }, "morale.ch": { "reason": "antisemitism, xenophobia, transphobia" }, "mastodon.staycuriousandkeepsmil.in": { "reason": "\"truth soldiers\", actually nazis/fash" }, "cawfee.club": { "reason": "weirdos, poa.st-adjacent" }, "pedo.school": { "reason": "..." }, "rigcz.club": { "reason": "transphobia, idiots" }, "merovingian.club": { "reason": "queerphobia" }, "geofront.rocks": { "reason": "racism, transphobia" }, "social.lovingexpressions.net": { "reason": "transphobia / admin sharing holocaust denial posts" }, "chudbuds.lol": { "reason": "transphobia" }, "annihilation.social": { "reason": "racist weirdos" }, "clubcyberia.co": { "reason": "transphobia / queerphobia" }, "brighteon.social": { "reason": "shady af, transphobic, pro-trump?" }, "netzsphaere.xyz": { "reason": "weirdos" }, "the.asbestos.cafe": { "reason": "rightists, weirdos, queerphobia, harassment of instance members" }, "flipboard.social": { "reason": "please do not litter, bad corpo" }, "federated.fun": { "reason": "rightist idiots" }, "comp.lain.la": { "reason": "weirdos, queerphobia, harassment of instance members" }, "normie.cafe": { "reason": "transphobia" }, "newsie.social": { "reason": "hosts righties. i don't vibe with the instance" }, "fedi.intkos.link": { "reason": "transphobia" }, "pkteerium.xyz": { "reason": "edgy rightie idiots; transphobia" }, "bronyfurry.com": { "reason": "anti-ukrainian xenophobia" }, "berserker.town": { "reason": "claims to be apolitical" }, "mugicha.club": { "reason": "transphobia" }, "pieville.net": { "reason": "transphobia / homophobia / racism" } } }, "quarantined_instances": [], "quarantined_instances_info": { "quarantined_instances": {} } }, "fieldsLimits": { "maxFields": 10, "maxRemoteFields": 20, "nameLength": 512, "valueLength": 2048 }, "invitesEnabled": false, "localBubbleInstances": [ "hackerspace.pl", "miau.jeder.pl", "is-a.cat", "mk.asie.pl", "wetdry.world", "lethallava.land", "seafoam.space", "toot.hackrc.dev", "ck.katzen.cafe" ], "mailerEnabled": true, "nodeDescription": "", "nodeName": "Do Not Stare", "pollLimits": { "max_expiration": 31536000, "max_option_chars": 200, "max_options": 32, "min_expiration": 0 }, "postFormats": [ "text/plain", "text/html", "text/markdown", "text/bbcode", "text/x.misskeymarkdown" ], "private": false, "privilegedStaff": true, "publicTimelineVisibility": { "bubble": false, "federated": true, "local": true }, "restrictedNicknames": [ ".well-known", "~", "about", "activities", "api", "auth", "check_password", "dev", "friend-requests", "inbox", "internal", "main", "media", "nodeinfo", "notice", "oauth", "objects", "ostatus_subscribe", "pleroma", "proxy", "push", "registration", "relay", "settings", "status", "tag", "user-search", "user_exists", "users", "web", "verify_credentials", "update_credentials", "relationships", "search", "confirmation_resend", "mfa" ], "skipThreadContainment": true, "staffAccounts": [ "https://donotsta.re/users/selfisekai", "https://donotsta.re/users/elly", "https://donotsta.re/users/domi" ], "suggestions": { "enabled": false }, "uploadLimits": { "avatar": 4194304, "background": 8388608, "banner": 8388608, "general": 268435456 } }, "openRegistrations": true, "protocols": [ "activitypub" ], "services": { "inbound": [], "outbound": [] }, "software": { "name": "akkoma", "version": "3.10.4-0-gebfb617" }, "usage": { "localPosts": 15189, "users": { "activeHalfyear": 45, "activeMonth": 29, "total": 83 } }, "version": "2.0" } }, "status_ttl_days": null, "permit_followback": false }, "avatar": "https://asdf.donotsta.re/media/d2a65ff459bb87926cae32060af7420abd074b959cadd6338473b64ffd32e858.png", "avatar_static": "https://asdf.donotsta.re/media/d2a65ff459bb87926cae32060af7420abd074b959cadd6338473b64ffd32e858.png", "bot": false, "display_name": "Wanda", "followers_count": 0, "fqn": "mwk@donotsta.re", "header_static": "https://asdf.donotsta.re/media/4175b393f29f2140933955a9f80ce09510db1da151c9676eee620007ac776701.jpg", "locked": true, "statuses_count": 25 }, "in_reply_to_account_id": null, "favourites_count": 0, "favourited": false, "reblog": null, "replies_count": 0 } ```

(Notice the quote property)

Clients that support showing quote posts, hide elements with the quote-inline class (in this case the RE:... sentence). Since GTS doesn't support quote posts (/ removes them), it should probably also remove that class

I'll forward this to GTS if it's not open and I can also add a check from Tuba's side to not hide it if there's not a quote property, but it should definitely be done from GTS' side too as other clients will also be affected by it

GeopJr commented 2 months ago

I can't test #927 right now but it should work if you want to cherry pick it! (nvm, wait)