search

GeopJr / Tuba

Browse the Fediverse
https://tuba.geopjr.dev/
GNU General Public License v3.0
503 stars 55 forks source link

snap: update for core24 #975

Closed soumyaDghosh closed 2 weeks ago

GeopJr commented 3 weeks ago

Thanks for this PR!

FWIW, this action and snap are only for ci artifacts and development builds. The release snap config lives at https://github.com/GeopJr/tuba-snap/ (you don't have to open a PR there, I'll pick the changes from here!)

soumyaDghosh commented 3 weeks ago

Thanks for this PR!

FWIW, this action and snap are only for ci artifacts and development builds. The release snap config lives at https://github.com/GeopJr/tuba-snap/ (you don't have to open a PR there, I'll pick the changes from here!)

You cannot directly build this in the snapcraft.io website builder. Because gnome extension still experimental.

GeopJr commented 3 weeks ago

:/ disappointing

soumyaDghosh commented 3 weeks ago

:/ disappointing

Actually the extensions are getting a major overhaul on the graphics side, with new graphics drivers. So, it's taking this long.

https://github.com/canonical/snapcraft/pull/4744

soumyaDghosh commented 3 weeks ago

You can get the login cradentials via this command,

snapcraft export-login --snaps=tuba \
  --acls package_access,package_release \
  SNAP_STORE_STABLE

Then set that in an environment variable named STORE_LOGIN

GeopJr commented 3 weeks ago

I'll do so when I get on my snap environment! Thanks!

I have one more question though, if it compiles with -Ddevel=true, how do I make 'stable' builds from here? If I promote the edge one, it will be treated as devel and the action is not aware of repo releases. That's one of the reasons I split it into devel snap config and release snap config in a different repo.

soumyaDghosh commented 3 weeks ago

I'll do so when I get on my snap environment! Thanks!

I have one more question though, if it compiles with -Ddevel=true, how do I make 'stable' builds from here? If I promote the edge one, it will be treated as devel and the action is not aware of repo releases. That's one of the reasons I split it into devel snap config and release snap config in a different repo.

Okay, so even more conditioning! Ummmm... For now I removed the devel using sed, but I think better you could do is replicate this in the snap manifests repo. And remove things from here which you don't need anymore.

GeopJr commented 3 weeks ago

Here's an idea: How about I unlink the tuba-snap repo from the snapcraft runners and we instead add an action there with (workflow_dispatch so I can trigger it manually) to build and publish snaps?

That way, the action on this repo can stay as devel and the action on tuba-snap will always be release only

GeopJr commented 2 weeks ago

Merging, thanks!

I don't know if/when I'll set up action publishing on the tuba-snap repo.

soumyaDghosh commented 6 days ago

Hi gnome+core24 now on stable

GeopJr commented 6 days ago

Thanks for letting me know!

Can I drop SNAPCRAFT_ENABLE_EXPERIMENTAL_EXTENSIONS?

soumyaDghosh commented 6 days ago

No Sorry, my bad, not yet. It's not yet stable. I hope in the next release of snapcraft, it'll be. And yes, you can drop it once stable