Geoportail-Luxembourg / geoportailv3

geoportailv3 is the implementation of the v3 of the map viewer of the luxembourgish geoportal
MIT License
25 stars 16 forks source link

Background layer question #147

Closed elemoine closed 9 years ago

elemoine commented 9 years ago

In https://github.com/camptocamp/ngeo/pull/133 I created a backgroundLayerMgr service and an example implementing a background layer selector based on that service. In that example a standard <select> element is used. The example can be seen at http://erilem.net/ngeo/backgroundlayer/backgroundlayer.html.

The question is: is using a regular <select> ok for the geoportailv3 project? The drawback of using <select> is that we can't customize the select caret (the small arrow) and the list of options displayed under the field. The advantage of using <select> is that it's simple to implement and it's natively accessible.

Another option is to use Bootstrap's dropdown JavaScript plugin. See the Bootstrap documentation for examples. I can work on a new example that uses Bootstrap downdown if using that makes more sense to people.

Please provide feedback.

jaykayone commented 9 years ago

Hi I'm not near a computer so I cannot check it myself. What was used in the prototype implemented by the designers?

Will a normal select fit into the design or will it necessarily be ugly?

I suspect that it will render diffenrently on diffenrent platforms and browsers which is not wantes

Jeff

On 14 janv. 2015, at 14:10, Éric Lemoine notifications@github.com wrote:

In camptocamp/ngeo#133 I created a backgroundLayerMgr service and an example implementing a background layer selector based on that service. In that example a standard ok for the geoportailv3 project? The drawback of using is that it's simple to implement and it's natively accessible.

Another option is to use Bootstrap's dropdown JavaScript plugin. See the Bootstrap documentation for examples. I can work on a new example that uses Bootstrap downdown if using that makes more sense to people.

Please provide feedback.

— Reply to this email directly or view it on GitHub.

elemoine commented 9 years ago

What was used in the prototype implemented by the designers?

A component that pushes the "my layers / catalog" panel down when the list opens. When we were in Lausanne we said that we weren't sure we'd keep that. See https://github.com/Geoportail-Luxembourg/geoportailv3/issues/6.

But, in the design prototype, the design of background layer is obviously well integrated with the rest of the page.

I suspect that it will render diffenrently on diffenrent platforms and browsers

Right.

which is not wantes

So this means we should try to use a Bootstrap (or Bootstrap-like) dropdown, right?

jaykayone commented 9 years ago

On 14 janv. 2015, at 15:04, Éric Lemoine notifications@github.com wrote:

What was used in the prototype implemented by the designers?

A component that pushes the "my layers / catalog" panel down when the list opens. When we were in Lausanne we said that we weren't sure we'd keep that. See #6.

RIGHT But, in the design prototype, the design of background layer is obviously well integrated with the rest of the page.

I suspect that it will render diffenrently on diffenrent platforms and browsers

Right.

which is not wantes

So this means we should try to use a Bootstrap (or Bootstrap-like) dropdown, right?

YES — Reply to this email directly or view it on GitHub.

elemoine commented 9 years ago

Here is a new example based on Angular Bootstrap's dropdown directive: http://erilem.net/ngeo/backgroundlayer2/backgroundlayerdropdown.html.

jaykayone commented 9 years ago

much better :)

pgiraud commented 9 years ago

Question answered. Closing.