search

Geoportail-Luxembourg / geoportailv3

geoportailv3 is the implementation of the v3 of the map viewer of the luxembourgish geoportal
MIT License
25 stars 16 forks source link

GSLUX-608: Use webpack uglify plugin #3079

Closed tkohr closed 2 months ago

tkohr commented 1 year ago

PR removes HardSourceWebpackPlugin and reactivates UglifyJsPlugin to minify prod js.

HardSourceWebpackPlugin makes build run out of memory when using UglifyJsPlugin for prod and seems to cause further problems in dev mode.

Edit: It seems to be the bundling of the two ol instances that actually cause the out of memory error with UglifyJsPlugin and not the HardSourceWebpackPlugin. So this PR depends on a lib version without ol. However, using such a version in v3 currently still causes conflicts between mapbox/maplibre. They must be resolved here or within the 3D PR first.

AlitaBernachot commented 12 months ago

Working good, thx!

But shouldn't we keep the HardSourceWebpackPlugin?

tkohr commented 12 months ago

You're right, I've removed the commit to get rid of the HardSourceWebpackPlugin here, as it is finally unrelated.

So we should wait to merge this PR until we use a v4 lib version without ol.

tkohr commented 2 months ago

Closing this, having been superseeded by https://github.com/Geoportail-Luxembourg/geoportailv3/pull/3143