Geoportail-Luxembourg / geoportailv3

geoportailv3 is the implementation of the v3 of the map viewer of the luxembourgish geoportal
MIT License
25 stars 16 forks source link

GSLUX-720: Fix reading permalink containing 3d_enabled #3174

Closed tkohr closed 1 month ago

tkohr commented 1 month ago

This PR should allow opening permalinks in 3D mode correctly (eg. https://migration.geoportail.lu/theme/main?version=3&X=662398&Y=6360606&zoom=18&lang=fr&rotation=0&bgLayer=streets_jpeg&crosshair=false&layers=&opacities=&time=&streets_jpeg=&serial=&3d_layers=ACT2022_BD_L_BATI3D_LOD2%2CVDL2022_LOD2_IMPORT_old%2CBridges_LOD2%2CACT2019_LiDAR_Bridges_LOD1%2CACT2019_LiDAR_Vegetation&3d_enabled=true&3d_lon=5.95042&3d_lat=49.49531&3d_elevation=696&3d_heading=360.000&3d_pitch=-39.984).

For the fix, the appLayerPermalinkManager.initBgLayers_() which returned an empty Promise is not called anymore. The included logic of the function already does not seem to be used anymore and was thus not migrated further into v4. The part regarding the tourisme theme could not be reproduced on production, and opacity logic only seems relevant for v2.

AlitaBernachot commented 1 month ago

LGTM, thanks for the fix!