Geoportail-Luxembourg / geoportailv3

geoportailv3 is the implementation of the v3 of the map viewer of the luxembourgish geoportal
MIT License
25 stars 16 forks source link

Use request.static_url #69

Closed elemoine closed 9 years ago

elemoine commented 9 years ago

The URLs to the static resources in ngeo.html look like this /node_modules/angular/angular.js. This is not correct: wrong URLs are created when mod_wsgi is used. request.static_url should be used.

jaykayone commented 9 years ago

This is a regression when we use a reverse proxy. I've used static_path instead and it is OK again: http://devv3.geoportail.lu/ngeo (only the _debugtoolbar still uses the wrong domain and I cannot find out why). can we undo this change please?

elemoine commented 9 years ago

We don't want to revert https://github.com/Geoportail-Luxembourg/geoportailv3/pull/77 we want to use route_path rather than route_url. I'll create a PR for that.

geoportallux commented 9 years ago

Ok thanks

Jeff Konnen Chargé d’études – informaticien/Chef de projet

LE GOUVERNEMENT DU GRAND-DUCHÉ DE LUXEMBOURG Ministère des Finances Administration du cadastre et de la topographie Service informatique & Service géoportail

54, avenue Gaston Diderich . L-1420 Luxembourg Tél. (+352) 44901-261 . Fax (+352) 44901-333 E-mail: jeff.konnen@act.etat.lu

www.act.public.lu www.geoportail.lu

De : Éric Lemoine notifications@github.com<mailto:notifications@github.com> Répondre à : Geoportail-Luxembourg/geoportailv3 reply@reply.github.com<mailto:reply@reply.github.com> Date : Wednesday 26 November 2014 15:35 À : Geoportail-Luxembourg/geoportailv3 geoportailv3@noreply.github.com<mailto:geoportailv3@noreply.github.com> Objet : Re: [geoportailv3] Use request.static_url (#69)

We don't want to revert #77https://github.com/Geoportail-Luxembourg/geoportailv3/pull/77 we want to use route_path rather than route_url. I'll create a PR for that.

— Reply to this email directly or view it on GitHubhttps://github.com/Geoportail-Luxembourg/geoportailv3/issues/69#issuecomment-64653722.

pgiraud commented 9 years ago

I think we can close this issue. It has been addressed in #90.