search

Geoportail-Luxembourg / geoportailv3

geoportailv3 is the implementation of the v3 of the map viewer of the luxembourgish geoportal
MIT License
25 stars 16 forks source link

print: Zoom to extent #759

Closed jaykayone closed 8 years ago

jaykayone commented 9 years ago

when changing the scale in print, the system should zoom out when the extent is bigger than the current map extent so that you can see the extent on screen. this has to be done in ngeo

jaykayone commented 9 years ago

@elemoine: Could you comment on this one please? Is this planned in ngeo?

jaykayone commented 8 years ago

just re-pinging @elemoine for this one

elemoine commented 8 years ago

If we zoom out the map when the user changes the print scale (in the case when the print rectangle is bigger than the map extent) then two things will move at the same time: the map and print mask. I wonder if this may confuse the user.

And if we do that will we also want to automatically change the print scale when the user zooms in the map? Again, two things will move at the same time, which may confuse the user.

I you still think it makes sense to zoom out the map when the print rectangle is bigger than the map extent then I can try to implement it so we can see what the user experience is.

Please comment.

jaykayone commented 8 years ago

@petzlux ?

petzlux commented 8 years ago

@elemoine , after talking with @jaykayone , can you please implement as discussed. We just want to give the user a visual hint of what will be printed, and this only works when the whole print extent is in view. We should just change the zoom level, not the map center, so that the print extent doesnt move.

elemoine commented 8 years ago

And if we do that will we also want to automatically change the print scale when the user zooms in the map?

What about this question?

jaykayone commented 8 years ago

yes that makes sense too

elemoine commented 8 years ago

yes that makes sense too

Ok, I'll start by adjusting the map zoom based on the print scale. And we'll see if we do it in the other direction as well.

petzlux commented 8 years ago

In my opinion, as it is now, is sufficient. I dont believe we need to change the print scale on zoom in. We want to stay consistent and only change print scale through the dropdown.

elemoine commented 8 years ago

In my opinion, as it is now, is sufficient. I dont believe we need to change the print scale on zoom in. We want to stay consistent and only change print scale through the dropdown.

Sounds good to me.

elemoine commented 8 years ago

Fixed with https://github.com/Geoportail-Luxembourg/geoportailv3/pull/899.