search

Geoportail-Luxembourg / geoportailv3

geoportailv3 is the implementation of the v3 of the map viewer of the luxembourgish geoportal
MIT License
25 stars 16 forks source link

Search: does not work anymore #839

Closed jaykayone closed 9 years ago

jaykayone commented 9 years ago

(Firefox on Mac): You cannot choose a result from the search anymore by hitting enter or clicking the result

Might be a build problem ... we'll see

jaykayone commented 9 years ago

@elemoine might this be a regression coming from ngeo? As @petzlux has not changed anything this week, I wonder where this regression might come from

elemoine commented 9 years ago

This is probably a regression introduced by https://github.com/Geoportail-Luxembourg/geoportailv3/pull/817.

jaykayone commented 9 years ago

I get an Error: Pattern length is too long in debug mode (console).

elemoine commented 9 years ago

I don't know what this means…

elemoine commented 9 years ago

Ok, we're fixing a regression introduced in typeahead 0.11.1. The regression is tracked by https://github.com/twitter/typeahead.js/issues/1313. And there is an (unmerged) PR here: https://github.com/twitter/typeahead.js/pull/1207.

One workaround would involve storing the dataset in the suggestion object, but this would require some work, as we handle different suggestion types.

Another option is to try to revert #817. This may just require adding a custom extern type for TypeaheadDataset. Not so bad I think.

It took me 1h to investigate the issue. I'll take me another hour or so to revert #817 and introduce the extern type override.

elemoine commented 9 years ago

I finally decided to make the revert PR. See #849. And it actually took me less than 1h.