search

Geoportail-Luxembourg / qgis-pag-plugin

Plugin QGIS pour la gestion des PAG du Ministère de l'Intérieur du Grand-Duché de Luxembourg
MIT License
1 stars 2 forks source link

Adapt for topology and geometrychecker plugin name changes in 3.28 #122

Open frankbroniewski opened 6 months ago

frankbroniewski commented 6 months ago

The names for the plugins Topology checker and Geometrychecker have changed in QGIS 3.28 and the current version of the plugin is not able to find these by iterating over the vector menu. This PR adds the new names to the conditional check so that the actions can be used in the plugin.

I have tested this with QGIS 3.28 on Windows, earlier versions of QGIS should continue to work as before. I also tested it with the latest version of QGIS 3.34 (Nightly). I cannot test the changes on Mac unfortunately ...

frankbroniewski commented 1 week ago

On QGIS 3.34 the plugin fails to start with the folllowing error:

2024-07-01T14:07:25     WARNING    Traceback (most recent call last):
              File "C:\Users/broniewski/AppData/Roaming/QGIS/QGIS3\profiles\default/python/plugins\PagLuxembourg\project.py", line 76, in open
              self._setupTopologicalSettings()
              File "C:\Users/broniewski/AppData/Roaming/QGIS/QGIS3\profiles\default/python/plugins\PagLuxembourg\project.py", line 253, in _setupTopologicalSettings
              QgsProject.instance().writeEntry('Digitizing', '/DefaultSnapTolerance', 10.0)
             TypeError: QgsProject.writeEntry(): arguments did not match any overloaded call:
              overload 1: argument 3 has unexpected type 'float'
              overload 2: argument 3 has unexpected type 'float'
              overload 3: argument 3 has unexpected type 'float'

which is fixed with the latest commit in the PR