search

Georacer / ardupilog

A ardupilot log to MATLAB converter
GNU General Public License v3.0
48 stars 36 forks source link

Bug: which() doesn't work as desired #58

Closed hunt0r closed 6 years ago

hunt0r commented 7 years ago

At the beginning of ArduPilog, if a filename is specified as the .BIN file, the InputParser should detect that as p.Results.path and call fileparts(which(p.Results.path)). (Line 47 of ArduPilog.m, I believe)

Unfortunately, which() doesn't seem to work as desired with files specified as 'path/to/file.ext'

I can demonstrate this at the command line. Having a valid file and typing: which('valid/path/to/valid_file.ext') returns: 'valid/path/to/valid_file.ext' not found. (<- this is incorrect)

While exist('valid/path/to/valid_file.ext') returns 2, indicating that a file is found and exists.

If I addpath('valid/path/to/') and then which('valid_file.ext') the function works as desired, returning: valid/path/to/valid_file.ext (<- as a MATLAB string)

I'm going to hack a quick workaround for now, but we should decide in the future some better fix.

Georacer commented 6 years ago

Probably matlab only acknowledges files that are inside its current path (i.e. scope). Not sure why exists works, but this isn't the only time Matlab is inconsistent.

hunt0r commented 6 years ago

Commit #62 commented out the call to MATLAB's offending which(), so I think we can declare this issue closed.