search

Georacer / ardupilog

A ardupilot log to MATLAB converter
GNU General Public License v3.0
48 stars 36 forks source link

Ardupilot system identification automation initial support #84

Open amilcarlucas opened 3 years ago

amilcarlucas commented 3 years ago

requires #86

I added more info to the top of the files

Georacer commented 3 years ago

I see that this depends on the previous PRs you made today, some of which need fixing.

We'll revisit this after we deal with those and you rebase, ok?

amilcarlucas commented 3 years ago

yeap, thanks.

Georacer commented 3 years ago

I'm having a hard time understanding what this PR is about. Looks like it plots the System Identification results, without doing any further manipulation. But I can't run it myself without the logs mentioned in sid_pre_config.m. Could you provide them?

Still, in a more general frame, Ardupilog was strictly meant to be a log converter, not focused on any specific application. If I understand your code correctly, it indeed does only visualization, but over more than one logs.

I'll have to give some more thought on whether it fits the Ardupilog purpose and how I could re-structure the codebase to include tools spanning more than one log. But, by all means, please provide the logs, it will make this process so much easier.

Thanks!

amilcarlucas commented 3 years ago

The example files are available here https://we.tl/t-KXhvCNx6LL

yes, I'm also not sure if the SID tool belongs in the Ardupilog repo, but the SID tool is a nice example on how to use Ardupilog.

And you do not need to re-structure Ardupilog to support multiple spanning .bin files.

Georacer commented 3 years ago

I was not aware of the system identification Mode in Arducopter. Cool stuff!

Yes, for sure this doesn't belong to the main Ardupilog repo, but I'd be happy to present this as a use-case. I could get a proper documentation page going (readthedocs or similar) and post it there.

I will probably need your help to make it an educational tutorial.

Are you ok with this approach?

amilcarlucas commented 3 years ago

Yes, I plan to continue to work on the tool, automating data import into the systemIdentification toolbox and eventually automate the entire system identification workflow.

I would love to collaborate.

Georacer commented 3 years ago

Hi Lucas, Since there's a separate "stable" branch now, I feel happy to merge this when you want, even if it's incomplete.

Just rebase on the current master, put the files in the gallery/sid folder and let me know.