Check BYPASS_GIFT_GAME_MODE also for recipient (partner) in gift comm…

GeorgH93 / MarriageMaster

Marriage Plugin for Bukkit/Spigot

https://www.spigotmc.org/resources/marriage-master.19273/

GNU General Public License v3.0

113 stars 90 forks source link

Check BYPASS_GIFT_GAME_MODE also for recipient (partner) in gift comm… #235

Closed Qveshn closed 2 years ago

Qveshn commented 2 years ago

…and.

Please consider adding "BYPASS_GIFT_GAME_MODE" check not only for the sender, but also for the recipient to the /marry gift command. IMHO: If the player has the ability to send gifts, then he should also be able to receive them. 😃

Qveshn commented 2 years ago

Hmm... I do not understand why "SonarCloud / Build (pull_request)" is failed 😟

GeorgH93 commented 2 years ago

Makes sense that the permission would also work for the receiver. Thanks.

I have no idea why SonarCloud constantly fails to pick up the token for this project. It's safe to ignore it for now in general, I haven't yet managed to set up the quality gates and rules for this project properly, so even if it would build it would probably be unhappy. As long as the Build/buildAndTest checks work, I am happy. :laughing: