search

GeorgH93 / MarriageMaster

Marriage Plugin for Bukkit/Spigot
https://www.spigotmc.org/resources/marriage-master.19273/
GNU General Public License v3.0
113 stars 90 forks source link

RGB Support #247

Open dipolo12q opened 2 years ago

dipolo12q commented 2 years ago

Feature request

Feature description

I'm sure I'm not the first to suggest this, but I use nicks and prefixes in RGB/hexa [&#], they look "ugly" in the married list or other marry messages. (of course for 1.16+)

btw, the plugin works pretty well and is going great.

How the feature is useful

It's a plus ("aesthetic compatibility"). I know many would like it.

kalleswe commented 2 years ago

Same here, this needs to be addresses. I though it should have been fixed by now. But apparently not. Please fix that it's not so hard. Make it in the next release please.

diademiemi commented 2 years ago

I can have a look at this tomorrow. I've just had to implement the mess that is per-character hex colours in text components for my own plugin today so I think I'll be able to get this working. I'll PR what I've got

GeorgH93 commented 2 years ago

The problem is how messages are handled within the plugin at the moment. Since, it is possible to put JSON formatted messages right into the language file (to allow for maximal customization). I have a working prototype for a fix, but it's still far away from a releasable state.

I simply don't have much time to work on the plugin, and that time that I have gets prioritized to breaking bugs.

diademiemi commented 2 years ago

Oh I see. If there's anything I can do to help get that prototype usable let me know, I'd be glad to help where I can.

GeorgH93 commented 2 years ago

Experimental support for RGB display names is now available on the dev branch (You can find the builds here, please note, that these early development builds require the PCGF PluginLib to be installed on your server).

There are still some things missing, mainly:

  1. Private chat on BungeeCord
  2. Some messages involving priests
  3. Multi partner into on connect/disconnect
  4. Marriage list (/marry list)

I have not fully tested everything yet, so there might be some issues. If you encounter any issues please let me know, and provide me with the full output of /marry version, as well as whats not working, whats happening and add your used language file as an attachment.

thiagogebrimm commented 2 years ago

DEV VERSION In the broadcast announce the RGB does not work and the nick color is white