search

George-Miao / qbit

A Rust library for interacting with qBittorrent's Web API
https://docs.rs/qbit-rs
MIT License
32 stars 12 forks source link

fix: missing fields on sync struct #8

Closed Lynnesbian closed 8 months ago

Lynnesbian commented 8 months ago

There are two (as of yet) undocumented fields on the sync endpoint that qbit does not currently support. These fields are trackers and trackers_removed, and they are similar to the categories and categories_removed fields.

I've opened a bug report against qBittorrent addressing this documentation error.

This commit adds the two fields to the SyncData struct.

Feel free to rewrite the doc comments, or to change the types. I wasn't quite sure what would fit best.

Thank you for your work on this project!

Lynnesbian commented 8 months ago

I've implemented another fix: The full_update field on the SyncData struct is now wrapped in Option. When the rid parameter is set to a previously returned value in the sync method, the API doesn't return a value for the full_update parameter.

George-Miao commented 8 months ago

LGTM. Thanks for the PR!