search

GeorgeCiesinski / text-script

An app that runs in the background and replaces text shortcuts with pre-saved blocks of text.
https://georgeciesinski.github.io/text-script/
GNU General Public License v3.0
72 stars 9 forks source link

Pyinstaller is not compatible with Python 3.8 #54

Closed GeorgeCiesinski closed 4 years ago

GeorgeCiesinski commented 4 years ago

Describe the bug This repository has recently been updated to Python 3.8, but this has caused issues generating executable files. Pyinstaller is not compatible with Python 3.8 yet as per this issue, and other python to executable libraries are similarly not able to convert Python 3.8 code at this time.

Although running pyinstaller results in an exe file, this exe crashes immediately at start. This seems to happen almost immediately before any code is ran, because it fails to initialize the logger as well, so no useful logs can be gathered from the crash.

To Reproduce Steps to reproduce the behavior:

  1. Navigate to the textscript directory
  2. Run pyinstaller on text-script.py
  3. Try to run the resulting exe file, which results in immediate crash.

Expected behavior The executable should either run successfully, or crash and generate logs.

Desktop (please complete the following information):

Next Steps I am currently looking into a work around to generate an executable while maintaining Python 3.8. If this fails, I will be looking to downgrade the python to the latest version compatible with Pyinstaller (I believe this is Python 3.7) and will see if this affects any of our current code.

Possible Issues There are a few other forks of this repository and a few collaborators working on this project. There is a small possibility that this downgrade might affect those collaborators.

GeorgeCiesinski commented 4 years ago

I have attempted to generate the .exe with auto-py-to-exe as well, but this also failed. There is an open issue here that also seems to point out Python 3.8 incompatibility. Although the problem seems to be resolved, this new release hasn't actually released yet.

GeorgeCiesinski commented 4 years ago

I decided to roll back the program to use Python 3.7. As per the updated README file:

Please be advised that I have decided to roll back to Python 3.7 as Pyinstaller, which we use to create executables, is not compatible with 3.8 yet. Once Pyinstaller supports 3.8, we will consider moving Text-Script back to this version as well. Sorry in advance if this causes any issues on your forks.

This was unfortunately necessary to prevent future issues with releases.