search

GeorgeSG / lovelace-time-picker-card

🕰️ Time Picker Card for Home Assistant's Lovelace UI
MIT License
209 stars 14 forks source link

Fix issue #43 #44

Closed OToussaint closed 2 years ago

OToussaint commented 2 years ago

Fix issue #43 HA 2022.11.0

GeorgeSG commented 2 years ago

Hey, thanks for the PR!

I don't have 2022.11 yet, but your description in #43 says this is only an issue when the card is used as embedded. If that's the case, the border: none definition should probably be under the ha-card.embedded css rule?

OToussaint commented 2 years ago

Hey, thanks for the PR!

I don't have 2022.11 yet, but your description in #43 says this is only an issue when the card is used as embedded. If that's the case, the border: none definition should probably be under the ha-card.embedded css rule?

You're right. HA 2022.11.0 is introducing a default border, no shadow to all cards by default. If you put it at ha-card level, HA will draw a border at the next element in the card and produce something like this:

image

My bad, did not update the way I did in my local version. Sorry.

GeorgeSG commented 2 years ago

OK, I will merge this as-is. I will not release a new version until 2022.11 is out and I test it though. In the meantime, you can set your version to master in HACS.

Thanks @OToussaint!