search

Georgetown-IR-Lab / QuickUMLS

System for Medical Concept Extraction and Linking
MIT License
369 stars 95 forks source link

_select_longest fcn identical to _select_score #25

Closed donghyun208 closed 6 years ago

donghyun208 commented 6 years ago

The two sort functions _select_score and _select_longest are identical: https://github.com/Georgetown-IR-Lab/QuickUMLS/blob/48564073c1fa85fb6c35e99b3c605545745e7ba4/quickumls.py#L265-L271

_select_longest should be:

def _select_longest(match): 
     return ((match[0]['end'] - match[0]['start']), match[0]['similarity'])
soldni commented 6 years ago

fixed in 1.2.4. Thanks for the report!