repeated similarity calculations

Georgetown-IR-Lab / QuickUMLS

System for Medical Concept Extraction and Linking

MIT License

369 stars 95 forks source link

repeated similarity calculations #56

Closed bicycleman15 closed 4 years ago

bicycleman15 commented 4 years ago

https://github.com/Georgetown-IR-Lab/QuickUMLS/blob/bad4c50ae654ec4ea0bb021d6861b7370ff1ae9f/quickumls/core.py#L326 I feel the similarity calculation could be moved one for loop above to line 324.

soldni commented 4 years ago

Hi @bicycleman15,

Thank you for letting me know -- I've just fixed it! This doesn't change execution time by much (calculating similarity is really fast, the bottleneck is retrieving candidates), so I'll push this out in the next release!

Best, Luca