search

Georgetown-IR-Lab / QuickUMLS

System for Medical Concept Extraction and Linking
MIT License
369 stars 95 forks source link

Issue 60 spacy entity overlap #61

Open burgersmoke opened 4 years ago

burgersmoke commented 4 years ago

This is an initial fix for what @soldni and I have discussed with spacy and overlapping entity spans. We may want to add additional match data later in an extension (i.e. the "underscore") but this works around an error for now.

https://github.com/Georgetown-IR-Lab/QuickUMLS/issues/60

burgersmoke commented 4 years ago

Sorry for the close/reopen but I was confused why this shows 4 commits instead of 1. The overall diff looks right, but please advise if there's a better way I should do this so that only the 1 commit (0dda67b) appears here.

soldni commented 3 years ago

Hey @burgersmoke,

Just a quick note to let you know that I've seen this PR, but I don't quite have the bandwidth at the moment to look at it closely.... hoping to come back to it over the upcoming weekend at the latest!

-Luca

burgersmoke commented 3 years ago

That sounds great @soldni. I understand the limitations of bandwidth since I initially planned to submit these pull requests back in October 2019 and then lots of things got in my way.

burgersmoke commented 3 years ago

Any update on this pull request? And perhaps bumping the version number in PyPi?

We're about to do a major release of medspacy (https://github.com/medspacy/medspacy) and we wanted to include QuickUMLS in our default pipeline if we could.