Georgetown-IR-Lab / QuickUMLS

System for Medical Concept Extraction and Linking
MIT License
369 stars 95 forks source link

fixed spacy language map issue #72

Closed McClain98 closed 3 years ago

McClain98 commented 3 years ago

Spacy updated d its language map so that it doesnt work with the shortened language names. I fixed this so the lang_map now works with spacy > 3

soldni commented 3 years ago

Hi @McClain98!

This is great! can you also update the requirement.txt file to require spacy > 3?

Thank, Luca

McClain98 commented 3 years ago

ok think its updated. thanks

soldni commented 3 years ago

one small change :) could you do spacy>=3.0.6 rather than spacy==3.0.6? Thanks again!

soldni commented 3 years ago

merged! thank you for fixing this issue.