replace setdefault with defaultdict

Georgetown-IR-Lab / cedr

Code for CEDR: Contextualized Embeddings for Document Ranking, accepted at SIGIR 2019.

MIT License

156 stars 28 forks source link

replace setdefault with defaultdict #8

Closed cmacdonald closed 4 years ago

cmacdonald commented 5 years ago

some of the code use for validation is a bit difficult to read due to the use of setdefault() - would you accept a PR for replacing this with defaultdict?

Craig

seanmacavaney commented 5 years ago

Yup, feel free to submit a PR.

seanmacavaney commented 4 years ago

Fixed with #25