GeorgetownMakerHubOrg / air-quality

An Open Source Platform For Georgetown's STIA Air Quality Courses
https://www.coursicle.com/georgetown/courses/STIA/436/
Other
4 stars 0 forks source link

Hardware Test Fails on Python 3 #30

Closed cmpadden closed 5 years ago

cmpadden commented 5 years ago

Describe the bug

subprocess.check_output returns bytes on Python 3, and a string on Python 2. Extracting the Chip ID was failing, as it could not parse the bytes.

To Reproduce

Run the upload.py script using Python 3.

python3 bin/upload.py --device /dev/tty.usbserial-1410

Expected behavior

Shouldn't throw an exception.

Desktop (please complete the following information):

cmpadden commented 5 years ago

Resolved in #31.