Open domenicoblanco opened 1 month ago
Thanks for the patch, I'll have a look this evening and give it a test on my machine.
Hmm just giving this a test locally looks like my version of SDB has a slightly different output.
When I run the command you added here I get devices
as well as my TV name:
root@9857af18aea2:~# sdb devices
List of devices attached
10.1.1.10:26101 device UA65RU7100WXXY
root@9857af18aea2:~# sdb devices | grep -E '\s{5}\w+' -o
device
UA65RU7100WXXY
root@9857af18aea2:~# sdb devices | grep -E '\s{5}\w+' -o | xargs
device UA65RU7100WXXY
Just out of interest what do you see in this case?
I'm trying from a container with the image from vitalets/tizen-webos-sdk
, my output is a bit different but with some tweak to the regex, I think that could be handled
root@d8a10f48cc24:~# sdb devices
List of devices attached
192.168.2.76:26101 device UJU6900
root@d8a10f48cc24:~# sdb devices | grep -E '\s{5}\w+' -o | xargs
UJU6900
Thanks for the updated fix, I'll check this out shortly. 🤞
Still haven't forgotten, sorry for the delay!
Don’t worry and take your time! c:
Some devices have different names available in the apis, this PR changes the way to obtain the device name from the API to the suggested
sdb devices
command.Tested with an UE50JU6900 and correctly returns UJU6900. It's not the same as asked in #11 but probably could close it