Closed BatchelorJ closed 3 years ago
@BatchelorJ, wow! That's mountain of work. These changes are well thought out, thanks for doing this. My only reservation is allowing HP notation to be stored as a float. Could cause problems?
I certainly agree that it can cause issues! Given that we've already implemented these functions with HP notation stored as floats in GeodePy previously, I didn't want to remove this functionality and break other users code. Also lots of other software stores HP notation as floats and I'm trying not to be too prescriptive, rather giving options for users to store data in a class if they want better type-certainty. It's more efficient but less safe to store HP notation as floats rather than in a class object, so for some applications floats may be preferred.
Point taken. Cheers