search

GeoscienceAustralia / GeodePy

A toolkit for Geodesy and Surveying in Python
Apache License 2.0
91 stars 47 forks source link

Refactor of Transformation Definitions in constants, add reverse transformations #133

Closed BatchelorJ closed 3 years ago

BatchelorJ commented 3 years ago

This PR standardizes the naming of transformation definitions in the constants module (resolves #129) and adds reverse transformations utilizing the same naming convention (resolves #127). Several other modules and tests that use some of these transformation objects have been refactored, and the names of functions that convert GDA2020 <-> ATRF2014 have been changed so that they have different names to the transformation objects themselves.

BatchelorJ commented 3 years ago

@BatchelorJ thanks for this. I am open to being convinced otherwise, but I think we should follow the standard names - as frustrating as they are. See my comment in test_transform.py

Thanks @harry093, I thought I'd throw this code up to see what we thought about it so thanks for the feedback. I'm happy to stick to the rule of years <2000 using 2-digit suffixes while >=2000 using 4-digit suffixes as long as it's consistently applied. Most in the geodetic and survey community understand this convention so we should be able to get away with it.