Introduction of a projection parameter for convert.py functions and ISG grid/geo conversion capability

GeoscienceAustralia / GeodePy

A toolkit for Geodesy and Surveying in Python

Apache License 2.0

91 stars 47 forks source link

Introduction of a projection parameter for convert.py functions and ISG grid/geo conversion capability #138

Closed jonathonpsmith closed 2 years ago

jonathonpsmith commented 2 years ago

Changes to various functions in convert.py to allow conversions by passing in an instance of a Projection object as a parameter. Various changes to allow easy conversions between AGD66 and the ISG projection for NSW users.

Remove the hardcoded 'proj' variable from convert.py and introduce a 'prj' parameter in the following functions:
- psfandgridconv()
- geo2grid()
- grid2geo()
Define new Projection instance 'isg' in constants.py
Add new functionality to calculate the zone and central meridian for ISG
Add new exceptions for invalid ISG zones (ISG is only valid in NSW)
Add a warning for non-recommended ellipsoid/projection combinations for ISG
Add new tests to test_convert.py to check the above new functionality.

nicgowans commented 2 years ago

More information on the Integrated Survey Grid projection and its historical implementation in NSW can be found at the NSW Spatial Services Map Projections page and in the ISG Technical Manual

harry093 commented 2 years ago

Thanks @jonathonpsmith and @nicgowans, this looks really useful. I have just run the checks and all seems to be in order. If I don't get to this this afternoon, I will on Monday. I will push a new version to PyPI, too

jonathonpsmith commented 2 years ago

Thanks Craig, sounds great. Glad I could be useful!

BatchelorJ commented 2 years ago

Hi @jonathonpsmith and @nicgowans, this looks really great! Happy that you've taken the projection concept to the next level. A couple of comments:

@harry093, as this change touches on some of the functions used in the GA geodesy apps, have these been tested and reviewed?
@jonathonpsmith, are you able to add a comment and link in geodepy.constants where isg is defined to help users find the references @nicgowans highlighted?

jonathonpsmith commented 2 years ago

Hey @BatchelorJ, yep too easy. I've added a description comment for ISG and both links that @nicgowans supplied, with a description of what each are.

I don't believe the projection parameter addition would affect any other functions, as it's defined with 'utm' as the default, which preserves the existing functionality.

harry093 commented 2 years ago

as this change touches on some of the functions used in the GA geodesy apps, have these been tested and reviewed?

@BatchelorJ, I agree with @jonathonpsmith that these changes should not break anything as prj is an optional argument that has a default value (utm) defined.

To be safe, though, after these changes have been pushed through to PyPI, we can update the version of Geodesy on the dev branch and make sure everything is working correctly.

harry093 commented 2 years ago

@jonathonpsmith @nicgowans @BatchelorJ - GeodePy v0.0.28 is now up on PyPI