Stop constructor for OptionsNuisance messing with its arguments

GeoscienceAustralia / HiQGA.jl

High Quality Geophysical Analysis provides a general purpose Bayesian and deterministic inversion framework for various geophysical methods and spatially distributed / timeseries data

MIT License

39 stars 5 forks source link

Stop constructor for OptionsNuisance messing with its arguments #4

Closed richardt94 closed 2 years ago

richardt94 commented 2 years ago

Fixes issues discussed in #3. I've also added some tests for the OptionsNuisance constructor to check for regressions and basic functionality - we should think about tests for the nuisance sampler itself as well.

a2ray commented 2 years ago

Good catch ... as we were only using Tempest earlier for nuisances within a loop of soundings, I fixed it further downstream than I should have here and bounds were not being assigned by reference ... this is a better place.