search

GeoscienceAustralia / PyRate

A Python tool for estimating velocity and time-series from Interferometric Synthetic Aperture Radar (InSAR) data.
https://geoscienceaustralia.github.io/PyRate/
Apache License 2.0
201 stars 71 forks source link

Rethink the application of 'maxsig' threshold parameter #247

Closed mcgarth closed 4 years ago

mcgarth commented 4 years ago

The parameter 'maxsig' for thresholding output ratemaps is providing user confusion, since if it is set too low the resulting output products are blank or very sparse. Based on this, we should move the application of maxsig to the ‘merge’ step, so that by re-running ‘merge’, you can quickly try different thresholds without having to re-run the full 'process' step.

In addition, here are a few options (increasing complexity):

  1. Discard maxsig completely (user can threshold themselves during post-processing).
  2. Give a screen message that describes the proportion of pixels that have been masked by the chosen maxsig threshold.
  3. Automatically estimate a reasonable maxsig threshold from the data set (several options to do that, e.g. using percentages or a histogram fit).

2 and 3 could be somehow combined by having maxsig set to ‘auto’ by default in the config file, but still allowing the user to manually set a value if need be.

mcgarth commented 4 years ago

I have started work on this issue in the branch: https://github.com/GeoscienceAustralia/PyRate/tree/mg/maxsig

mcgarth commented 4 years ago

This has been resolved by PR #269, now merged into 'develop' branch