Change units of time and space input parameters?

GeoscienceAustralia / PyRate

A Python tool for estimating velocity and time-series from Interferometric Synthetic Aperture Radar (InSAR) data.

https://geoscienceaustralia.github.io/PyRate/

Apache License 2.0

201 stars 71 forks source link

Change units of time and space input parameters? #257

Closed mcgarth closed 3 years ago

mcgarth commented 4 years ago

tlpfcutoff is a temporal filter cutoff time, currently in units of years slpfcutoff is a spatial filter cutoff length, currently in units of kilometres.

Are these the best choices of units? Could alternatively be days or metres respectively. What is more intuitive for the user?

mcgarth commented 3 years ago

As part of my current refactoring work on the APS module, I will change tlpfcutoff to units of days and keep slpfcutoff in units of kilometres

mcgarth commented 3 years ago

tlpfcutoff was changed to units of days in https://github.com/GeoscienceAustralia/PyRate/commit/57d57ffec1076ca8d4167b601994b89dade0c7af

slpfcutoff remains in units of kilometres.

merged to develop branch in https://github.com/GeoscienceAustralia/PyRate/commit/edbe6048d080832ffd331694ebbf53e75c969119