search

GeoscienceAustralia / PyRate

A Python tool for estimating velocity and time-series from Interferometric Synthetic Aperture Radar (InSAR) data.
https://geoscienceaustralia.github.io/PyRate/
Apache License 2.0
201 stars 71 forks source link

Sb/refpixel lat lon #272

Closed basaks closed 4 years ago

basaks commented 4 years ago

Adds lat/lon refpixel and tests around it

codecov-commenter commented 4 years ago

Codecov Report

Merging #272 into develop will increase coverage by 0.36%. The diff coverage is 96.49%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #272      +/-   ##
===========================================
+ Coverage    92.78%   93.14%   +0.36%     
===========================================
  Files           25       26       +1     
  Lines         3089     3195     +106     
  Branches       494      495       +1     
===========================================
+ Hits          2866     2976     +110     
+ Misses         138      137       -1     
+ Partials        85       82       -3
Impacted Files Coverage Δ
pyrate/core/refpixel.py 91.81% <93.10%> (-1.05%) :arrow_down:
pyrate/core/ifgconstants.py 100.00% <100.00%> (ø)
pyrate/core/prepifg_helper.py 95.17% <100.00%> (+0.03%) :arrow_up:
pyrate/core/shared.py 95.24% <100.00%> (+2.20%) :arrow_up:
pyrate/prepifg.py 97.61% <100.00%> (-1.57%) :arrow_down:
pyrate/process.py 91.78% <100.00%> (+0.31%) :arrow_up:
pyrate/constants.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 20507ba...3f25d50. Read the comment docs.

tfuhrmann commented 4 years ago

I've re-run my real data test using the latest commit (rounding). The lat/lon to pixel coordinate conversion is now delivering exactly the same output as gdallocationinfo for the first reference area, but still off by one pixel for the second reference area (see below command line output). I think the small difference of one pixel for some locations is accectable.

PyRate command line output: ref area 1: Converted reference pixel coordinate (x, y): (563, 227) ref area 2: Converted reference pixel coordinate (x, y): (117, 501)